Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI for new release of grunt-dojo2 #331

Merged
merged 2 commits into from
Oct 27, 2017

Conversation

bryanforbes
Copy link
Member

Type: enhancement

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

grunt-dojo2 has been updated in a PR to use Intern 4 exclusively which includes a reporter similar to the one developed for Intern 3. This PR updates the CI scripts to use these features and return the grunt tasks back to feature parity with the tasks before the Intern 4 conversion. The grunt-dojo2 PR MUST LAND and be released before this can land.

@bryanforbes bryanforbes requested a review from kitsonk October 24, 2017 21:50
@dylans dylans added this to the 2017.10 milestone Oct 27, 2017
@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #331 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          24       24           
  Lines        1718     1718           
  Branches      447      447           
=======================================
  Hits         1703     1703           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96646e4...c470704. Read the comment docs.

@bryanforbes bryanforbes merged commit c0c1002 into dojo:master Oct 27, 2017
@bryanforbes bryanforbes deleted the intern-4-ci branch October 27, 2017 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants